Re: [Xen-devel] [PATCH v12 06/11] x86/hvm/ioreq: add a new mappable resource type...

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Paul,

On 10/19/2017 01:58 PM, Paul Durrant wrote:
> > -----Original Message-----
> > From: Julien Grall [mailto:julien.grall@xxxxxxxxxx]
> > Sent: 19 October 2017 13:31
> > To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> > Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>; Wei Liu
> > <wei.liu2@xxxxxxxxxx>; Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>;
> > George Dunlap <George.Dunlap@xxxxxxxxxx>; Andrew Cooper
> > <Andrew.Cooper3@xxxxxxxxxx>; Ian Jackson <Ian.Jackson@xxxxxxxxxx>; Tim
> > (Xen.org) <tim@xxxxxxx>; Jan Beulich <jbeulich@xxxxxxxx>
> > Subject: Re: [Xen-devel] [PATCH v12 06/11] x86/hvm/ioreq: add a new
> > mappable resource type...
> >
> > Hi,
> >
> > On 17/10/17 14:24, Paul Durrant wrote:
> > > diff --git a/xen/common/memory.c b/xen/common/memory.c
> > > index cdd2e030cf..b27a71c4f1 100644
> > > --- a/xen/common/memory.c
> > > +++ b/xen/common/memory.c
> > > @@ -1011,6 +1011,11 @@ static int acquire_resource(
> > >
> > >        switch ( xmar.type )
> > >        {
> > > +    case XENMEM_resource_ioreq_server:
> > > +        rc = xenmem_acquire_ioreq_server(d, xmar.id, xmar.frame,
> > > +                                         xmar.nr_frames, mfn_list);
> > > +        break;
> > I fully appreciate you are not able to test on x86. However, I would
> > have expected you to at least build test it.
> I don't actually know how to set up cross-compilation, which is why I'd 
> originally #ifdef-ed this.
It is quite trivial. See 
https://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions#Cross_Compiling
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel