Re: [Xen-devel] [PATCH v12 06/11] x86/hvm/ioreq: add a new mappable resource type...

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi,

On 17/10/17 14:24, Paul Durrant wrote:
> diff --git a/xen/common/memory.c b/xen/common/memory.c
> index cdd2e030cf..b27a71c4f1 100644
> --- a/xen/common/memory.c
> +++ b/xen/common/memory.c
> @@ -1011,6 +1011,11 @@ static int acquire_resource(
>   
>       switch ( xmar.type )
>       {
> +    case XENMEM_resource_ioreq_server:
> +        rc = xenmem_acquire_ioreq_server(d, xmar.id, xmar.frame,
> +                                         xmar.nr_frames, mfn_list);
> +        break;
I fully appreciate you are not able to test on x86. However, I would 
have expected you to at least build test it.
For instance, here you introduced this function on x86, call in common 
code but does not introduce it on Arm.
Although, I don't think we should introduce it for Arm. Instead we 
should provide arch helpers as we do for other memory operations.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel