Re: [Xen-devel] [PATCH] Update xl.cfg files for Xen 4.10 support

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Oct 06, 2017 at 01:15:11PM +0000, Andrew Cooper wrote:
> On 06/10/17 14:10, Roger Pau Monné wrote:
> > On Fri, Oct 06, 2017 at 12:46:31PM +0000, Andrew Cooper wrote:
> >> From 4.10 onwards, the configuration file should use type= in preference to
> >> builder/loader.  Leave the older options for legacy compatability.
> >>
> >> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >> ---
> >> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> >> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> >> ---
> >>  config/default-hvm.cfg.in | 5 ++++-
> >>  config/default-pv.cfg.in  | 5 ++++-
> >>  2 files changed, 8 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/config/default-hvm.cfg.in b/config/default-hvm.cfg.in
> >> index 0de2546..c410eff 100644
> >> --- a/config/default-hvm.cfg.in
> >> +++ b/config/default-hvm.cfg.in
> >> @@ -1,5 +1,8 @@
> >>  name="test-@@ENV@@-@@NAME@@@@VARIATION@@"
> >> -builder="hvm"
> >> +
> >> +type="hvm"
> >> +builder="hvm" # Legacy for before Xen 4.10
> > Since this examples are only for >= Xen 4.10, does it really make
> > sense to keep the builder option here?
> >
> > Do we expect people to mix and match example configuration files?
> 
> There is only one version of XTF.  It doesn't branch for different
> versions of Xen, so needs to support them all.

Oh, I was confused and thought this was a patch to the xl.cfg example
files in xen.get, sorry.

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel