Re: [Xen-devel] [PATCH v3 10/22] libxl: add PVH support to domain creation

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Sep 27, 2017 at 02:28:11PM +0000, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v3 10/22] libxl: add PVH support to domain 
> creation"):
> > Remove the device model "none" support from domain creation and
> > introduce support for PVH.
> 
> This is a backwards-incompatible change, which at the very least
> requires justification.  The facility seems to have been introduced in
> 
>   libxl: allow the creation of HVM domains without a device model.
>   5ca88cb7582a19636646c1a39c739fdbcaf3362a
> 
> which was part of the original PVH2 work, I think.  I'm not sure how
> explicitly we need to have marked the interface as unstable but we
> probably did somewhere.  Perhaps you could introduce an appropriate
> reference in the commit message ?

I cannot find any written down references to the interface being
unstable, I think it was mostly based on me replying to people on the
mailing list saying that this interface was not stable, and that
people shouldn't rely on it.

But is this a backwards incompatible change? By removing
LIBXL_HAVE_DEVICE_MODEL_VERSION_NONE there should be no breakage to
libxl downstreams, as long as they used the macro properly.

Let me reply to patch 10 with an expanded commit message.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel