Re: [Xen-devel] [PATCH v3 10/22] libxl: add PVH support to domain creation

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v3 10/22] libxl: add PVH support to domain 
creation"):
> Remove the device model "none" support from domain creation and
> introduce support for PVH.

This is a backwards-incompatible change, which at the very least
requires justification.  The facility seems to have been introduced in

  libxl: allow the creation of HVM domains without a device model.
  5ca88cb7582a19636646c1a39c739fdbcaf3362a

which was part of the original PVH2 work, I think.  I'm not sure how
explicitly we need to have marked the interface as unstable but we
probably did somewhere.  Perhaps you could introduce an appropriate
reference in the commit message ?

The code changes seem fine to me.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel