Re: [Xen-devel] [PATCH v2] x86emul/test: generate non-pie executable for 64bit builds

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Sep 25, 2017 at 08:25:43AM -0600, Jan Beulich wrote:
> >>> On 25.09.17 at 16:11, <wei.liu2@xxxxxxxxxx> wrote:
> > On Mon, Sep 25, 2017 at 07:58:15AM -0600, Jan Beulich wrote:
> >> Wouldn't it be better then to pass both (as
> >> long as supported, if we really care about older compilers here)?
> > 
> > I'm fine with that. -fno-PIE is supported a long time ago. I can fold in
> > the following diff to this patch.
> > 
> > diff --git a/tools/tests/x86_emulator/Makefile
> > b/tools/tests/x86_emulator/Makefile
> > index 87064494d1..fbe02cd2f9 100644
> > --- a/tools/tests/x86_emulator/Makefile
> > +++ b/tools/tests/x86_emulator/Makefile
> > @@ -98,7 +98,7 @@ asm:
> > 
> >  asm/%: asm ;
> > 
> > -HOSTCFLAGS-x86_64 :=
> > +HOSTCFLAGS-x86_64 := -fno-PIE
> >  $(call cc-option-add,HOSTCFLAGS-x86_64,HOSTCC,-no-pie)
> >  HOSTCFLAGS += $(CFLAGS_xeninclude) -I.  $(HOSTCFLAGS-$(XEN_COMPILE_ARCH))
> 
> Feel free to commit with that addition (or tell me that I should),
> or maybe Andrew could give his ack.
> 

I will commit it soon. I will add your ack too.

> Thanks for your help here, Jan
> 

You're welcome.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel