Re: [Xen-devel] [PATCH v3 11/15] tools: implement the new xl get hw info interface

[Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>]

On 17-09-19 11:32:19, Roger Pau Monn� wrote:
> On Tue, Sep 05, 2017 at 05:32:33PM +0800, Yi Sun wrote:
> > index 6baaed2..a01245d 100644
> > --- a/tools/xl/xl_cmdtable.c
> > +++ b/tools/xl/xl_cmdtable.c
> > +static int psr_mba_hwinfo(void)
> > +{
> > +    int rc;
> > +    unsigned int i, nr;
> > +    libxl_psr_hw_info *info;
> > +
> > +    rc = libxl_psr_get_hw_info(ctx, &info, &nr,
> > +                               LIBXL_PSR_FEAT_TYPE_MBA, 0);
> > +    if (rc)
> > +        return rc;
> > +
> > +    printf("Memory Bandwidth Allocation (MBA):\n");
> > +
> > +    for (i = 0; i < nr; i++) {
> > +        printf("Socket ID               : %u\n", info[i].id);
> > +        printf("Linear Mode             : %s\n",
> > +               info[i].u.mba.linear ? "Enabled" : "Disabled");
> > +        printf("Maximum COS             : %u\n", info[i].u.mba.cos_max);
> > +        printf("Maximum Throttling Value: %u\n", info[i].u.mba.thrtl_max);
> > +        printf("Default Throttling Value: %u\n", 0);
> 
> What's the point in printing a default value if it's always 0? Ie:
> this can be on the docs, but I don't think is meaningful here.
> 
This follows the convention of CAT. It shows the default CBM.

> Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel