Re: [Xen-devel] [PATCH 03/22] xentoolcore, _restrict_all: Introduce new library and implementation

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Sep 15, 2017 at 07:48:40PM +0100, Ian Jackson wrote:
> +
> +int xentoolcore_restrict_all(uint32_t domid) {
> +/* xxx lock */
> +    int r;
> +    Xentoolcore__Active_Handle *ah;
> +
> +    lock();
> +    XENTOOLCORE_LIST_FOREACH(ah, &handles, entry) {
> +        r = ah->restrict_callback(ah, domid);

Looking at the "Implement" patches for some libraries, I think we need
to stash domid in ah and filter base on that. If not, at least in the
case of duping /dev/null, we risk closing the handles we don't wish to
close.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel