Re: [Xen-devel] [PATCH 03/22] xentoolcore, _restrict_all: Introduce new library and implementation

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Sep 18, 2017 at 05:08:18PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH 03/22] xentoolcore, _restrict_all: Introduce new 
> library and implementation"):
> > On Fri, Sep 15, 2017 at 07:48:40PM +0100, Ian Jackson wrote:
> ...
> > > +void xentoolcore__register_active_handle(Xentoolcore__Active_Handle*);
> > > +void xentoolcore__deregister_active_handle(Xentoolcore__Active_Handle*);
> > 
> > Why use two underscores in those function names?
> 
> These functions are for use by other Xen libraries only, not by
> external callers.
> 
> > Is this library supposed to be stable? We only expect this to be tech
> > review, right?  I think it is worth explicitly stating that if that's
> > the case.
> 
> The API/ABI to xentoolcore_restrict_all is intended to be stable.
> The internal API may vary.
> 
> The head comment of xentoolcore_internal.h says
>    * Interfaces of xentoolcore directed internally at other Xen libraries
> but I can make this more explicit if you want.

There is no need for that.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel