Re: [Xen-devel] [PATCH 09/12] arm/decode.c: switch to plain bool

[Julien Grall <julien.grall@xxxxxxx>]

On 09/15/2017 03:39 PM, Wei Liu wrote:
> On Fri, Sep 15, 2017 at 03:33:27PM +0100, Julien Grall wrote:
> > Hi Wei,
> >
> > On 09/15/2017 10:42 AM, Wei Liu wrote:
> > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > > ---
> > >    xen/arch/arm/decode.c | 6 +++---
> > >    1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
> > > index 514b7a21a5..795d126f02 100644
> > > --- a/xen/arch/arm/decode.c
> > > +++ b/xen/arch/arm/decode.c
> > > @@ -26,7 +26,7 @@
> > >    #include "decode.h"
> > >    static void update_dabt(struct hsr_dabt *dabt, int reg,
> > > -                        uint8_t size, bool_t sign)
> > > +                        uint8_t size, bool sign)
> > You probably want to switch from 0 to false all the callers of update_dabt.
> The following diff will be folded in.
Looks good to me.

Cheers,

> diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c
> index 795d126f02..8b1e15d118 100644
> --- a/xen/arch/arm/decode.c
> +++ b/xen/arch/arm/decode.c
> @@ -101,16 +101,16 @@ static int decode_thumb(register_t pc, struct
> hsr_dabt *dabt)
>           switch ( opB & 0x3 )
>           {
>           case 0: /* Non-signed word */
> -            update_dabt(dabt, reg, 2, 0);
> +            update_dabt(dabt, reg, 2, false);
>               break;
>           case 1: /* Non-signed halfword */
> -            update_dabt(dabt, reg, 1, 0);
> +            update_dabt(dabt, reg, 1, false);
>               break;
>           case 2: /* Non-signed byte */
> -            update_dabt(dabt, reg, 0, 0);
> +            update_dabt(dabt, reg, 0, false);
>               break;
>           case 3: /* Signed byte */
> -            update_dabt(dabt, reg, 0, 1);
> +            update_dabt(dabt, reg, 0, true);
>               break;
>           }
>
> @@ -118,19 +118,19 @@ static int decode_thumb(register_t pc, struct
> hsr_dabt *dabt)
>       }
>       case 6:
>           /* Load/Store word immediate offset */
> -        update_dabt(dabt, instr & 7, 2, 0);
> +        update_dabt(dabt, instr & 7, 2, false);
>           break;
>       case 7:
>           /* Load/Store byte immediate offset */
> -        update_dabt(dabt, instr & 7, 0, 0);
> +        update_dabt(dabt, instr & 7, 0, false);
>           break;
>       case 8:
>           /* Load/Store halfword immediate offset */
> -        update_dabt(dabt, instr & 7, 1, 0);
> +        update_dabt(dabt, instr & 7, 1, false);
>           break;
>       case 9:
>           /* Load/Store word sp offset */
> -        update_dabt(dabt, (instr >> 8) & 7, 2, 0);
> +        update_dabt(dabt, (instr >> 8) & 7, 2, false);
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel