Re: [Xen-devel] [PATCH 12/12] arm: use plain bool in various headers

[Julien Grall <julien.grall@xxxxxxx>]

Hi Wei,

On 09/15/2017 10:42 AM, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>   xen/include/asm-arm/altp2m.h       | 4 ++--
>   xen/include/asm-arm/arm64/insn.h   | 2 +-
>   xen/include/asm-arm/domain.h       | 2 +-
>   xen/include/asm-arm/guest_access.h | 2 +-
>   xen/include/asm-arm/p2m.h          | 8 ++++----
>   5 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/xen/include/asm-arm/altp2m.h b/xen/include/asm-arm/altp2m.h
> index a87747a291..df50cb2f09 100644
> --- a/xen/include/asm-arm/altp2m.h
> +++ b/xen/include/asm-arm/altp2m.h
> @@ -22,10 +22,10 @@
>   #include <xen/sched.h>
>   
>   /* Alternate p2m on/off per domain */
> -static inline bool_t altp2m_active(const struct domain *d)
> +static inline bool altp2m_active(const struct domain *d)
>   {
>       /* Not implemented on ARM. */
> -    return 0;
> +    return false;
>   }
>   
>   /* Alternate p2m VCPU */
> diff --git a/xen/include/asm-arm/arm64/insn.h b/xen/include/asm-arm/arm64/insn.h
> index 2ec4ad7c7f..4e0d364d41 100644
> --- a/xen/include/asm-arm/arm64/insn.h
> +++ b/xen/include/asm-arm/arm64/insn.h
> @@ -55,7 +55,7 @@ enum aarch64_insn_branch_type {
>   };
>   
>   #define	__AARCH64_INSN_FUNCS(abbr, mask, val)	\
> -static always_inline bool_t aarch64_insn_is_##abbr(u32 code) \
> +static always_inline bool aarch64_insn_is_##abbr(u32 code) \
Hmmm, I am not sure why this was turned to a bool_t at first the hand. 
This file was supposed to be a copy of the Linux version.
Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel