Re: [Xen-devel] [PATCH 02/12] arm/{v,}gic: switch to plain bool

[Julien Grall <julien.grall@xxxxxxx>]

Hi Wei,

On 09/15/2017 10:42 AM, Wei Liu wrote:
> diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
> index 6203dc59f4..977e75b1d2 100644
> --- a/xen/include/asm-arm/gic.h
> +++ b/xen/include/asm-arm/gic.h
> @@ -345,7 +345,7 @@ struct gic_hw_operations {
>       void (*update_lr)(int lr, const struct pending_irq *pending_irq,
>                         unsigned int state);
>       /* Update HCR status register */
> -    void (*update_hcr_status)(uint32_t flag, bool_t set);
> +    void (*update_hcr_status)(uint32_t flag, bool set);
The callers of update_hcr_status are still using 1/0 (see 
arch/arm/gic.c). Would you mind to fix it?
I can also send a follow-up patch :).

>       /* Clear LR register */
>       void (*clear_lr)(int lr);
>       /* Read LR register and populate gic_lr structure */
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel