Re: [Xen-devel] [PATCH v4 10/13] libxl: change nic to use generec add function

[Oleksandr Grytsov <al1img@xxxxxxxxx>]

On Tue, Sep 5, 2017 at 4:03 PM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> On Tue, Jul 18, 2017 at 05:25:27PM +0300, Oleksandr Grytsov wrote:
>> From: Oleksandr Grytsov <oleksandr_grytsov@xxxxxxxx>
>>
>> Signed-off-by: Oleksandr Grytsov <oleksandr_grytsov@xxxxxxxx>
>> diff --git a/tools/libxl/libxl_nic.c b/tools/libxl/libxl_nic.c
>> index dd07a6c..16a6c8c 100644
>> --- a/tools/libxl/libxl_nic.c
>> +++ b/tools/libxl/libxl_nic.c
>> @@ -20,15 +20,18 @@
>>  int libxl_mac_to_device_nic(libxl_ctx *ctx, uint32_t domid,
>>                              const char *mac, libxl_device_nic *nic)
>>  {
>> +    GC_INIT(ctx);
>>      libxl_device_nic *nics;
>>      int nb, rc, i;
>>      libxl_mac mac_n;
>>
>> +    libxl_device_nic_init(nic);
>> +
>
> Why is this change introduced?
>
> This is changing the behaviour of the API.
>
> To be clear I don't think its original behaviour is desirable. But if
> you are to change it, please make a separate patch.

Yes, the behavior is changed. I will revert these changes.

>>      rc = libxl__parse_mac(mac, mac_n);
>>      if (rc)
>>          return rc;
>>
>> -    nics = libxl_device_nic_list(ctx, domid, &nb);
>> +    nics = libxl__device_list(gc, &libxl__nic_devtype, domid, "vif", &nb);
>>      if (!nics)
>>          return ERROR_FAIL;
>>



-- 
Best Regards,
Oleksandr Grytsov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel