Re: [Xen-devel] [PATCH v2] x86/pvh: remove stale HVM/PVHv1 comment from public headers

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Aug 31, 2017 at 09:16:35AM -0600, Jan Beulich wrote:
> >>> On 31.08.17 at 17:10, <roger.pau@xxxxxxxxxx> wrote:
> > Changes since v1:
> >  - Completely remove the comment, HVM guests also use
> >    vcpu_hvm_context instead of vcpu_guest_context.
> 
> Are you sure? Specifically for ...
> 
> > --- a/xen/include/public/arch-x86/xen.h
> > +++ b/xen/include/public/arch-x86/xen.h
> > @@ -161,15 +161,6 @@ typedef uint64_t tsc_timestamp_t; /* RDTSC timestamp */
> >  /*
> >   * The following is all CPU context. Note that the fpu_ctxt block is filled
> >   * in by FXSAVE if the CPU has feature FXSR; otherwise FSAVE is used.
> > - *
> > - * Also note that when calling DOMCTL_setvcpucontext and VCPUOP_initialise
> 
> ... the DOMCTL_setvcpucontext part.

Right, I couldn't change DOMCTL_setvcpucontext to use the new struct
because it was already in use by gdbsx.

So v1 is the right version.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel