[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] acpi: set correct address of the control/event blocks in the FADT

>>> On 29.08.17 at 10:50, <roger.pau@xxxxxxxxxx> wrote:
> Commit 149c6b unmasked an issue long present in Xen: the control/event
> block addresses provided in the ACPI FADT table where hardcoded to the
> V1 version. This was papered over because hvmloader would also always
> set HVM_PARAM_ACPI_IOPORTS_LOCATION to 1 regardless of the BIOS
> version.
> Fix this by passing the address of the control/event blocks to
> acpi_build_tables, so the values can be properly set in the FADT
> table provided to the guest.
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

The patch here looks good, i.e. could have my R-b, just that it is
entirely unclear to me how things did work before the quoted
commit: Ports used by Xen and qemu-trad must have been out of
sync, or am I overlooking something?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.