[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH V2 9/25] tools/libxl: build DMAR table for a guest with one virtual VTD
- To: Lan Tianyu <tianyu.lan@xxxxxxxxx>
- From: Wei Liu <wei.liu2@xxxxxxxxxx>
- Date: Fri, 25 Aug 2017 10:11:31 +0100
- Cc: kevin.tian@xxxxxxxxx, Wei Liu <wei.liu2@xxxxxxxxxx>, andrew.cooper3@xxxxxxxxxx, ian.jackson@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxx, julien.grall@xxxxxxx, jbeulich@xxxxxxxx, "Gao, Chao" <chao.gao@xxxxxxxxx>
- Delivery-date: Fri, 25 Aug 2017 09:11:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Fri, Aug 25, 2017 at 03:33:47PM +0800, Lan Tianyu wrote:
> >
> > int libxl__arch_domain_finalise_hw_description(libxl__gc *gc,
> > libxl_domain_build_info
> > *info,
> > struct xc_dom_image *dom)
> > {
> > int rc = 0;
> >
> > if ((info->type == LIBXL_DOMAIN_TYPE_HVM) &&
> > (info->device_model_version == LIBXL_DEVICE_MODEL_VERSION_NONE)) {
> > rc = libxl__dom_load_acpi(gc, info, dom);
> > if (rc != 0)
> > LOGE(ERROR, "libxl_dom_load_acpi failed");
> > }
> >
> > return rc;
> > }
>
> We may remove the check and move introduced code in
> libxl__dom_load_acpi(). Run new code just for hvm guest. Does this make
> sense?
>
More or less. Push the check down to libxl__dom_load_acpi
> --
> Best regards
> Tianyu Lan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
