Re: [Xen-devel] [PATCH V2 3/25] VIOMMU: Add get irq info callback to convert irq remapping request

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.08.17 at 17:38, <roger.pau@xxxxxxxxxx> wrote:
> On Wed, Aug 09, 2017 at 04:34:04PM -0400, Lan Tianyu wrote:
>> --- a/xen/common/viommu.c
>> +++ b/xen/common/viommu.c
>> @@ -213,6 +213,22 @@ int viommu_handle_irq_request(struct domain *d, u32 
>> viommu_id,
>>      return info->viommu[viommu_id]->ops->handle_irq_request(d, request);
>>  }
>>  
>> +int viommu_get_irq_info(struct domain *d, u32 viommu_id,
>> +                        struct irq_remapping_request *request,
>> +                        struct irq_remapping_info *irq_info)
> 
> The definition of this struct seems to be arch-specific, in which case
> IMHO it should be called arch_irq_remapping_info, in order to denote
> it's arch-specific.

In which case it also wouldn't belong in this file.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel