Re: [Xen-devel] [PATCH v3 20/52] xen/arch/x86/shutdown.c: let custom parameter parsing routines return errno

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.08.17 at 10:40, <jgross@xxxxxxxx> wrote:
> On 22/08/17 11:53, Jan Beulich wrote:
>>>>> On 16.08.17 at 14:51, <jgross@xxxxxxxx> wrote:
>>> @@ -82,6 +87,8 @@ static void __init set_reboot_type(char *str)
>>>  
>>>      if ( reboot_type == BOOT_EFI && !efi_enabled(EFI_RS) )
>>>          reboot_type = BOOT_INVALID;
>> 
>> Should this perhaps also lead to -EINVAL being returned?
> 
> Hmm, I'm not sure. The parameter as such was valid.
> 
> So maybe a message right here would be the better solution?

I'd be fine with that too, it's just that with the overall change
your series does this shouldn't go silent anymore.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel