Re: [Xen-devel] [PATCH v3 33/52] xen/drivers/passthrough/iommu.c: let custom parameter parsing routines return errno

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.08.17 at 14:52, <jgross@xxxxxxxx> wrote:
> @@ -89,44 +89,50 @@ static void __init parse_iommu_param(char *s)
>              s += 3;
>  
>          ss = strchr(s, ',');
> -        if ( ss )
> -            *ss = '\0';
> -
> -        if ( !parse_bool(s) )
> -            iommu_enable = 0;
> -        else if ( !strcmp(s, "force") || !strcmp(s, "required") )
> +        if ( !ss )
> +            ss = strchr(s, '\0');
> +
> +        b = parse_bool(s);

I don't think this will work as intended for "iommu=yes,...". Did I
perhaps overlook the same issue in some of the earlier patches?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel