Re: [Xen-devel] [PATCH v1 11/13] tools: implemet new get value interface suitable for all psr allocation features

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

On Tue, 2017-08-22 at 10:24 +0800, Yi Sun wrote:
> On 17-08-21 18:14:49, Chao Peng wrote:
> > 
> > 
> > > 
> > >  
> > > -static void libxl__psr_cat_log_err_msg(libxl__gc *gc, int err)
> > > +static void libxl__psr_alloc_log_err_msg(libxl__gc *gc,
> > > +                                         int err,
> > > +                                         libxl_psr_cbm_type type)
> > >  {
> > > +    /*
> > > +     * Index is 'libxl_psr_cbm_type' so we set two 'CDP' to
> > > correspond to
> > > +     * DATA and CODE.
> > > +     */
> > 
> > Or just use "CDP CODE" and "CDP DATA" respectively?
> > 
> They are just value type but not feature name. So, I duplicate 'CDP'
> here.

I'm fine.

Chao
> 
> > 
> > > 
> > > +    const char * const feat_name[6] = {
> > > +        "UNKNOWN",
> > > +        "L3 CAT",
> > > +        "CDP",
> > > +        "CDP",
> > > +        "L2 CAT",
> > > +        "MBA",
> > > +    };
> > >      char *msg;
> > >  

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel