Re: [Xen-devel] [PATCH v4 06/31] x86: move pv_emul_is_mem_write to pv/emulate.c

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 18/08/17 13:08, Wei Liu wrote:
> On Fri, Aug 18, 2017 at 04:08:44AM -0600, Jan Beulich wrote:
>>
>> If it can't be static anymore, and considering it's just a wrapper
>> around another function call, would there be anything wrong with
>> making it an inline function in the header?
> Yes it can be done:
>
> ---8<---
> From 129ea54249114f97fe66b85672f1710c5f63f604 Mon Sep 17 00:00:00 2001
> From: Wei Liu <wei.liu2@xxxxxxxxxx>
> Date: Wed, 19 Jul 2017 16:15:48 +0100
> Subject: [PATCH] x86: move pv_emul_is_mem_write to pv/emulate.h
>
> Make it a static inline function in pv/emulate.h.  In the mean time it
> is required to include pv/emulate.h in x86/mm.c.
>
> The said function will be used later by different emulation handlers
> in later patches.
>
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel