Re: [Xen-devel] [PATCH v4 06/31] x86: move pv_emul_is_mem_write to pv/emulate.c

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.08.17 at 16:44, <wei.liu2@xxxxxxxxxx> wrote:
> @@ -5138,13 +5140,6 @@ static int ptwr_emulated_cmpxchg(
>          container_of(ctxt, struct ptwr_emulate_ctxt, ctxt));
>  }
>  
> -static int pv_emul_is_mem_write(const struct x86_emulate_state *state,
> -                                struct x86_emulate_ctxt *ctxt)
> -{
> -    return x86_insn_is_mem_write(state, ctxt) ? X86EMUL_OKAY
> -                                              : X86EMUL_UNHANDLEABLE;
> -}

If it can't be static anymore, and considering it's just a wrapper
around another function call, would there be anything wrong with
making it an inline function in the header?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel