Re: [Xen-devel] [PATCH 11/11] xen/arm: Limit the scope of cpregs.h

[Julien Grall <julien.grall@xxxxxxx>]

On 17/08/17 08:30, Bhupinder Thakur wrote:
> Hi Julien,
Hi Bhupinder,

> On 11 August 2017 at 23:32, Julien Grall <julien.grall@xxxxxxx> wrote:
> > Currently, cpregs.h is included in pretty much every files even for
> > arm64. However, the only use for arm64 is when emulating co-processors.
> >
> > For arm32, cpregs.h rely on the presence of processor.h (define
> > *_SYSREG helpers). So move the inclusion in asm-arm/arm32/processor.h.
> Should it say that processor.h relies on cpregs.h instead of the other
> way round because processor.h
> includes cpregs.h?
I can reword to "For arm32, all the users of processor.h expects 
cpregs.h to be included in order to access co-processors. So move the 
inclusion in ....".
> > cpregs.h will also be directly included in the co-processors emulation
> > to accomodate arm64.
Just noticed a typo here. I will fix it.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel