Re: [Xen-devel] [PATCH 07/11] xen/arm: traps: Export a bunch of helpers to handle emulation

[Julien Grall <julien.grall@xxxxxxx>]

On 16/08/17 10:30, Bhupinder Thakur wrote:
> Hi Julien,
Hi Bhupinder,

> On 11 August 2017 at 23:32, Julien Grall <julien.grall@xxxxxxx> wrote:
> > diff --git a/xen/include/asm-arm/arm64/traps.h 
> > b/xen/include/asm-arm/arm64/traps.h
> > new file mode 100644
> > index 0000000000..5cb45df6bd
> > --- /dev/null
> > +++ b/xen/include/asm-arm/arm64/traps.h
> > @@ -0,0 +1,15 @@
> > +#ifndef __ASM_ARM32_TRAPS__
> > +#define __ASM_ARM32_TRAPS__
> I think it should be __ASM_ARM64_TRAPS__ here.
Hmmm yes and ...

> > +
> > +void inject_undef64_exception(struct cpu_user_regs *regs, int instr_len);
> > +
> > +#endif /* __ASM_ARM32_TRAPS__ */
here too. I will fix it in the next version.

> > +/*
> > + * Local variables:
> > + * mode: C
> > + * c-file-style: "BSD"
> > + * c-basic-offset: 4
> > + * indent-tabs-mode: nil
> > + * End:
> > + */
> > +
> > diff --git a/xen/include/asm-arm/traps.h b/xen/include/asm-arm/traps.h
> > new file mode 100644
> > index 0000000000..4e227c4dd2
> > --- /dev/null
> > +++ b/xen/include/asm-arm/traps.h
> > @@ -0,0 +1,35 @@
> > +#ifndef __ASM_ARM_TRAPS__
> > +#define __ASM_ARM_TRAPS__
> > +
> > +#include <asm/processor.h>
> > +
> > +#if defined(CONFIG_ARM_32)
> > +# include <asm/arm32/traps.h>
> > +#elif defined(CONFIG_ARM_64)
> > +# include <asm/arm64/traps.h>
> > +#endif
> > +
> > +int check_conditional_instr(struct cpu_user_regs *regs, const union hsr hsr);
> a newline can be added here.
I will do that.

> > +void advance_pc(struct cpu_user_regs *regs, const union hsr hsr);
> > +
> > +void inject_undef_exception(struct cpu_user_regs *regs, const union hsr hsr);
> > +
> > +void handle_raz_wi(struct cpu_user_regs *regs, int regidx, bool read,
> > +                   const union hsr hsr, int min_el);
> > +
> > +void handle_wo_wi(struct cpu_user_regs *regs, int regidx, bool read,
> > +                  const union hsr hsr, int min_el);
> > +
> > +void handle_ro_raz(struct cpu_user_regs *regs, int regidx, bool read,
> > +                   const union hsr hsr, int min_el);
> > +
> > +#endif /* __ASM_ARM_TRAPS__ */
> > +/*
> > + * Local variables:
> > + * mode: C
> > + * c-file-style: "BSD"
> > + * c-basic-offset: 4
> > + * indent-tabs-mode: nil
> > + * End:
> > + */
> > +
> > --
> > 2.11.0
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel