[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v1 09/13] tools: implement the new get hw info interface suitable to all psr allocation features
On Wed, Aug 09, 2017 at 03:41:48PM +0800, Yi Sun wrote: > This patch implements a new get hw info interface suitable for all psr > allocation > features and the whole flow. It also enables MBA support in tools to get MBA > HW info. > > Signed-off-by: Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx> I would suggest you add to the commit message to better describe the content of the patch. Like: Introduce a bunch of things in libxc ... Implement a new function on libxl to do XXX, the existing function libxl_psr_cat_get_info is changed to use the new function ... And then you will discover certain things are better split out to separate patches so reviewers can more easily review / ack them. I have gone through this patch. The code looks sensible but I'm not yet confident to say it is alright. I would appreciate you break this patch down a bit if possible. I will leave reviewing the xl bits to Chao -- he knows the relationship between various features better than I do. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |