Re: [Xen-devel] [PATCH 39/52] xen: check parameter validity when parsing command line

[Juergen Gross <jgross@xxxxxxxx>]

On 10/08/17 15:32, Jan Beulich wrote:
>>>> On 10.08.17 at 15:24, <jgross@xxxxxxxx> wrote:
>> @@ -176,7 +200,8 @@ int __init parse_bool(const char *s)
>>           !strcmp("on", s) ||
>>           !strcmp("true", s) ||
>>           !strcmp("enable", s) ||
>> -         !strcmp("1", s) )
>> +         !strcmp("1", s) ||
>> +         !strcmp("", s) )
> 
> But not strcmp() please in such a case - !*s is quite sufficient there.

Okay.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel