[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/7] arm: make processor-specific functions from traps.c globaly visible

On 09/08/2017 20:26, Volodymyr Babchuk wrote:
Hi Julien,

Hi Volodymyr,

On 09.08.17 12:53, Julien Grall wrote:
Hi Volodymyr,

On 08/08/17 21:08, Volodymyr Babchuk wrote:
From: Volodymyr Babchuk <vlad.babchuk@xxxxxxxxx>

The following list of functions:

 - advance_pc()
 - check_conditional_instr()
 - inject_undef_exception()
 - inject_iabt_exception()
 - inject_dabt_exception()
 - inject_vabt_exception()

are now globaly visible. This change is needed becase we plan to
handle SMCs
in different file and handler code needs to alter state of a guest.

Signed-off-by: Volodymyr Babchuk <vlad.babchuk@xxxxxxxxx>
 xen/arch/arm/traps.c            | 16 ++++++----------
 xen/include/asm-arm/processor.h | 11 +++++++++++

I would much prefer if you introduce a new header traps.h rather than
piggy-back on the now growing processor.h.
Probably, better idea is to move this functions to processor.c or to
newlycreated file like processor_state.c, because actually this
functions can
have broader use, than traps handling. What do you think?

processor.c deals with the physical processor whilst those are for the guest. The same for processor_state.c.

IHMO, they are fine to stay in traps.c for now as it is dealing with traps. If you really want to move it in the separate file, then please introduce vtraps.c.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.