Re: [Xen-devel] [PATCH 2/7] arm: make processor-specific functions from traps.c globaly visible

[Julien Grall <julien.grall@xxxxxxx>]

Hi Volodymyr,

On 08/08/17 21:08, Volodymyr Babchuk wrote:
> From: Volodymyr Babchuk <vlad.babchuk@xxxxxxxxx>
>
> The following list of functions:
>
>  - advance_pc()
>  - check_conditional_instr()
>  - inject_undef_exception()
>  - inject_iabt_exception()
>  - inject_dabt_exception()
>  - inject_vabt_exception()
>
> are now globaly visible. This change is needed becase we plan to handle SMCs
> in different file and handler code needs to alter state of a guest.
>
> Signed-off-by: Volodymyr Babchuk <vlad.babchuk@xxxxxxxxx>
> ---
>  xen/arch/arm/traps.c            | 16 ++++++----------
>  xen/include/asm-arm/processor.h | 11 +++++++++++
I would much prefer if you introduce a new header traps.h rather than 
piggy-back on the now growing processor.h.
I have actually a series that will do that, but I am happy if you 
introduce it before me.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel