Re: [Xen-devel] [PATCH v5 02/17] rbtree: remove redundant if()-condition in rb_erase()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.07.17 at 10:26, <kpraveen.lkml@xxxxxxxxx> wrote:
> --- a/xen/common/rbtree.c
> +++ b/xen/common/rbtree.c
> @@ -250,15 +250,16 @@ void rb_erase(struct rb_node *node, struct rb_root 
> *root)
>                       if (child)
>                               rb_set_parent(child, parent);
>                       parent->rb_left = child;
> +
> +                     node->rb_right = old->rb_right;
> +                     rb_set_parent(old->rb_right, node);
>               }
>  
>               node->rb_parent_color = old->rb_parent_color;
> -             node->rb_right = old->rb_right;
>               node->rb_left = old->rb_left;
>  
>               rb_set_parent(old->rb_left, node);

The original Linux commit also removes the blank line above. Once
again, for ease of future patch application, please _do not_ alter
the original commits unless you really can't avoid it.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel