Re: [Xen-devel] [PATCH v14 16/23] x86: L2 CAT: implement CPU init flow.

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx> 07/15/17 2:49 AM >>>
>@@ -273,6 +275,12 @@ static int cat_init_feature(const struct cpuid_leaf *regs,
>struct psr_socket_info *info,
>enum psr_feat_type type)
>{
>+    const char * const cat_feat_name[FEAT_TYPE_NUM] = {

Strictly speaking the blank after the star is wrong here.

>+        "L3 CAT",
>+        "CDP",
>+        "L2 CAT",
>+    };

Please use designated initializers here.

With at least this second aspect taken care of
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel