Re: [Xen-devel] [PATCH v7 20/20] osstest: save/retrieve the last successfully tested FreeBSD build

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Tue, Jul 25, 2017 at 04:18:52PM +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH v7 20/20] osstest: save/retrieve the last 
> successfully tested FreeBSD build"):
> > And use it in order to install the hosts for the next FreeBSD flight.
> ...
> > +case "$branch" in
> > +freebsd-*)
> > +    IFS=$'\n'
> 
> That's quite brave, but I don't object.  I would have piped the output
> into `read' or something.

Yes, I think that would be better, let me do that as a patch on top of
this afterwards. I'm currently building the new images and I cannot
play freely with osstest ATM.

> > +    for anointed in \> +        `./mg-anoint list-prepared "freebsd build 
> > $freebsd_branch*"`; do
>                                                                     ^
> I think there is a missing space between $freebsd_branch and * ?
> 
> > +IFS=$'\n'
> > +for anointed in \
> > +    `./mg-anoint list-prepared "freebsd build $freebsd_branch*"`; do
> > +    # Retrieve previous successful FreeBSD build for each arch.
> > +    freebsd_arch=${anointed##* }
> > +    freebsd_envvar="FREEBSD_${freebsd_arch^^}_BUILDJOB"
> > +    if [ "x${!freebsd_envvar}" = "x" ]; then
> > +        flight_job=`./mg-anoint retrieve "$anointed"`
> > +        export ${freebsd_envvar}=${flight_job/ /.}
> > +    fi
> > +done
> > +unset IFS
> 
> LGTM apart from the same missing space.
> 
> So if you add those spaces:
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Thanks, I've now pushed this (also with the other acks) to:

git://xenbits.xen.org/people/royger/osstest.git freebsd_v8

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel