Re: [Xen-devel] [PATCH] xen-blkfront: Fix handling of non-supported operations

[Bart Van Assche <Bart.VanAssche@xxxxxxx>]

On Mon, 2017-07-24 at 08:46 -0600, Jens Axboe wrote:
> On 07/21/2017 11:11 AM, Bart Van Assche wrote:
> > This patch fixes the following sparse warnings:
> > 
> > drivers/block/xen-blkfront.c:916:45: warning: incorrect type in argument 2 
> > (different base types)
> > drivers/block/xen-blkfront.c:916:45:    expected restricted blk_status_t 
> > [usertype] error
> > drivers/block/xen-blkfront.c:916:45:    got int [signed] error
> > drivers/block/xen-blkfront.c:1599:47: warning: incorrect type in assignment 
> > (different base types)
> > drivers/block/xen-blkfront.c:1599:47:    expected int [signed] error
> > drivers/block/xen-blkfront.c:1599:47:    got restricted blk_status_t 
> > [usertype] <noident>
> > drivers/block/xen-blkfront.c:1607:55: warning: incorrect type in assignment 
> > (different base types)
> > drivers/block/xen-blkfront.c:1607:55:    expected int [signed] error
> > drivers/block/xen-blkfront.c:1607:55:    got restricted blk_status_t 
> > [usertype] <noident>
> > drivers/block/xen-blkfront.c:1625:55: warning: incorrect type in assignment 
> > (different base types)
> > drivers/block/xen-blkfront.c:1625:55:    expected int [signed] error
> > drivers/block/xen-blkfront.c:1625:55:    got restricted blk_status_t 
> > [usertype] <noident>
> > drivers/block/xen-blkfront.c:1628:62: warning: restricted blk_status_t 
> > degrades to integer
> > 
> > Compile-tested only.
> 
> Applied, but I killed your stable tag. Why did you add that?

Hello Jens,

That tag was added based on the output of git describe:
$ git describe 2a842acab109
v4.12-rc2-199-g2a842acab109

However, the following command shows that the above output is misleading and 
that the
stable tag is indeed not needed:
$ git log v4.12..origin/master | grep '^commit 2a842acab109'            
commit 2a842acab109f40f0d7d10b38e9ca88390628996

Bart.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel