Re: [Xen-devel] [PATCH v5 13/17] osstest: introduce a script to set the runtime hostflags runvar for FreeBSD jobs

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v5 13/17] osstest: introduce a script to set 
the runtime hostflags runvar for FreeBSD jobs"):
> Due to the nature of the FreeBSD install media, which is
> self-generated from the ts-freebsd-build script, the hostflags runvar
> set to FreeBSD jobs are related to the current version under test.
> 
> The following hostflags might need to be fetched from the runvars of a
> previous build-$arch-freebsd job:
...
> +our $share;
> +if (@ARGV && $ARGV[0] eq "--share") {
> +    $share = 1;
> +    shift @ARGV;
> +}

I think the remaining arguments should be host idents.

Also you should check that the first ident doesn't start with -.
(simply calling die if it does is fine).

> +my $version = get_freebsd_version();
> +set_runtime_hostflag("host", "freebsd-$version");

Specifically, you should iterate that, and this ...

> +if ($share) {
> +    my $hash = get_freebsd_image_hash();
> +
> +    set_runtime_hostflag("host", "share-build-freebsd-$hash");
> +}

for each entry in @ARGV.

That way this script can be used for pair tests etc.

ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel