Re: [Xen-devel] [PATCH v5 01/17] rbtree: changes to align the coding conventions with Linux tree

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.07.17 at 14:51, <kpraveen.lkml@xxxxxxxxx> wrote:
> On Fri, 2017-07-14 at 06:28 -0600, Jan Beulich wrote:
>> > 
>> > > 
>> > > > 
>> > > > On 14.07.17 at 10:26, <kpraveen.lkml@xxxxxxxxx> wrote:
>> > The patch aligns the coding style of rbtree related files to Linux
>> > coding
>> > conventions to have limited conflicts in future while porting from
>> > Linux 
>> > tree.
>> > 
>> > This patch includes only the style changes.
>> 
>> Certainly not: In the header you introduce at least 3 new inline
>> functions. Please be _really_ careful with such statements.
>> 
> Agreed, I shouldn't have added.
> rbtree.h file does include incline functions which are actually
> commented, and in order to have complete similarity I did include the
> same here.
> 
> Also, rbtree.c does have comment in header note being modified, for the
> same reason.
> 
> Further, do you suggest to keep the old ones, but that may cause
> porting issue and it won't be exact replica from Linux base. Please
> suggest.

I'm fine with comment updates, _as long as you say so_ in the
commit message. If you say "only style changes", then there
ought to be no additions whatsoever.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel