Re: [Xen-devel] [PATCH v4 15/16] osstest: introduce a script to create a FreeBSD flight

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH v4 15/16] osstest: introduce a script to create 
a FreeBSD flight"):
> The logic to create a FreeBSD build job is added to
> make-freebsd-flight. This includes creating a FreeBSD build job, and
> also testing the output of that build job (by creating another build
> job that depends on the output of the first).
...
> +get_freebsdjob_runvars () {
> +    # Figure out where are the installer binaries. The order is the follo\
wing:
> +    #
> +    # 1. Env variable FREEBSD_BUILDJOB: use the output from a previous
> +    # build-<arch>-freebsd.
> +    #
> +    # 2. Env variables FREEBSD_DIST, FREEBSD_VERSION: set before calling \
into

Please rewrap this to 70 or 75 columns.

> +    echo $runvars

Can you follow the calling pattern of set_hostos_runvars ?

I think the runvars variable should probably be "freebsd_runvars"
and the function "set_freebsd_runvars".

> +runvars=`get_freebsdjob_runvars`
> +job_create_build build-$arch-freebsd build-freebsd                       \
> +            arch=$arch                                                   \
> +            $RUNVARS $BUILD_RUNVARS $BUILD_FREEBSD_RUNVARS $arch_runvars \
> +            tree_freebsd=$TREE_FREEBSD                                   \
> +            revision_freebsd=$REVISION_FREEBSD                           \
> +            host_hostflags=arch-$arch,purpose-build                      \
> +            $runvars
> +
> +# Create an identical job that's going to use the build output from
> +# the previous one.
> +job_create_build build-$arch-freebsd-again build-freebsd                 \
> +            arch=$arch                                                   \
> +            $RUNVARS $BUILD_RUNVARS $BUILD_FREEBSD_RUNVARS $arch_runvars \
> +            host_hostflags=arch-$arch,purpose-build                      \
> +            tree_freebsd=$TREE_FREEBSD                                   \
> +            revision_freebsd=$REVISION_FREEBSD                           \
> +            freebsdbuildjob=build-$arch-freebsd

Perhaps set_freebsd_runvars could set host_hostflags too ?
Not sure.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel