[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RTDS Patch v3 for Xen4.8]

>>> On 03.07.17 at 19:09, <dario.faggioli@xxxxxxxxxx> wrote:
> On Mon, 2017-07-03 at 11:17 -0500, Haoran Li wrote:
>> From: naroahlee <naroahlee@xxxxxxxxx>
>>  When more than one idle VCPUs that have
>>  the same PCPU as their previous running core invoke runq_tickle(),
>> they will
>>  tickle the same PCPU. The tickled PCPU will only pick at most one
>> VCPU, i.e.,
>>  the highest-priority one, to execute. The other VCPUs will not be
>> scheduled
>>  for a period, even when there is an idle core, making these VCPUs
>>  unnecessarily starve for one period. Therefore, always make sure
>> that we only
>>  tickle PCPUs that have not been tickled already.
>> Signed-off-by: Haoran Li <naroahlee@xxxxxxxxx>
>> Reviewed-by:   Meng Xu   <mengxu@xxxxxxxxxxxxx>
> So, from what I can see from the 'From' tag, and from the pieces of
> emails, that appear below the patch, this is some kind of
> resubmission/new version, of a patch sent a while back.
> However, the subject seems to have changed... Or in any case, the
> current subject is no good.
> It's also a bit unusual, and definitely not comfortable for people
> managing the patch, to have a quoted email conversation below the patch
> itself (or so I think). So, please, remove it.
> Finally, in that quoted email conversation, I asked for some changes,
> and said that, with them done, my Reviewed-by: would stand.
> Have you made those changes? If yes, please, mention this somewhere
> (Ideally, between the S-o-b, R-b tags and the patch itself, after a
> '---' mark).

Additionally, you would almost never submit patches for other than
the unstable staging branch. The only exception being if there's a
change that absolutely has to go into an older branch, but which
isn't applicable at all anymore to current staging.

If you do your development on an older version, so be it. But for
submission it is you who is responsible for doing (and testing!) the
forward port.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.