[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RTDS Patch v3 for Xen4.8]

Hi Haoran,

On Mon, Jul 3, 2017 at 12:17 PM, Haoran Li <naroahlee@xxxxxxxxx> wrote:
> From: naroahlee <naroahlee@xxxxxxxxx>
>  When more than one idle VCPUs that have
>  the same PCPU as their previous running core invoke runq_tickle(), they will
>  tickle the same PCPU. The tickled PCPU will only pick at most one VCPU, i.e.,
>  the highest-priority one, to execute. The other VCPUs will not be scheduled
>  for a period, even when there is an idle core, making these VCPUs
>  unnecessarily starve for one period. Therefore, always make sure that we only
>  tickle PCPUs that have not been tickled already.
> Signed-off-by: Haoran Li <naroahlee@xxxxxxxxx>
> Reviewed-by:   Meng Xu   <mengxu@xxxxxxxxxxxxx>

As Dario mentioned in the email, the title should be changed and the
email should be a new email thread, instead of a forward email.

A reference to the format of sending a newer version of patch can be
found at https://www.mail-archive.com/xen-devel@xxxxxxxxxxxxx/msg60115.html

In the commit message, you can add
Changes to the v1
to state the changes made from the previous versions.
You can also refer to the previous discussion with a link in that section..
This makes the reviewers' life easier.
The change log won't be committed.

Could you please send another version after resolving the concerns
raised by Dario and me?

Don't hesitate to ping me if you have any question.



Meng Xu
PhD Candidate in Computer and Information Science
University of Pennsylvania

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.