[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH for-4.8] x86/pv: Fix the handling of `int $x` for vectors which alias exceptions
>>> On 22.06.17 at 21:12, <andrew.cooper3@xxxxxxxxxx> wrote: > The claim at the top of c/s 2e426d6eecf "x86/traps: Drop use_error_code > parameter from do_{,guest_}trap()" is only actually true for hardware > exceptions. It is not true for `int $x` instructions (which never push error > code), irrespective of whether the vector aliases an exception or not. > > Furthermore, c/s 6480cc6280e "x86/traps: Fix failed ASSERT() in > do_guest_trap()" really should have helped highlight that a regression had > been introduced. > > Modify pv_inject_event() to understand event types other than > X86_EVENTTYPE_HW_EXCEPTION, and introduce pv_inject_sw_interrupt() for the > `int $x` handling code. > > Add further assertions to pv_inject_event() concerning the type of events > passed in, which in turn requires that do_guest_trap() set its type > appropriately (which is now used exclusively for hardware exceptions). > > This is logically a backport of c/s 5c4f579e0ee4f38cad5636bbf8ce700a394338d0 > from Xen 4.9, but disentangled from the other injection work. > > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Thanks, applied. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |