[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v4 04/27] x86: move PV invalid op emulation code
On Wed, Jun 21, 2017 at 03:26:12AM -0600, Jan Beulich wrote: > >>> On 21.06.17 at 11:14, <wei.liu2@xxxxxxxxxx> wrote: > > On Wed, Jun 21, 2017 at 03:09:41AM -0600, Jan Beulich wrote: > >> >>> On 21.06.17 at 10:57, <wei.liu2@xxxxxxxxxx> wrote: > >> > +int pv_emulate_invalid_op(struct cpu_user_regs *regs) > >> > +{ > >> > + return !emulate_invalid_rdtscp(regs) && > >> > !emulate_forced_invalid_op(regs); > >> > +} > >> > >> This way you want to make the function return bool. Alternatively > >> you would want to preserve the EXCRET_* return value here, and > >> handle it accordingly in the caller. > >> > > > > I will just make it return bool. Do you want me to send another version? > > No need to I think - feel free to add my ack. > Cool. Thank you. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |