Re: [Xen-devel] [PATCH v4 04/27] x86: move PV invalid op emulation code

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.06.17 at 19:11, <wei.liu2@xxxxxxxxxx> wrote:
> @@ -1053,8 +982,8 @@ void do_invalid_op(struct cpu_user_regs *regs)
>  
>      if ( likely(guest_mode(regs)) )
>      {
> -        if ( !emulate_invalid_rdtscp(regs) &&
> -             !emulate_forced_invalid_op(regs) )
> +        if ( !pv_emulate_invalid_rdtscp(regs) &&
> +             !pv_emulate_forced_invalid_op(regs) )

I wonder if the first couldn't be called by the second, making it
unnecessary to export both. Or maybe have a wrapper
pv_emulate_invalid_op() around both.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel