Re: [Xen-devel] [PATCH 01/14 v4] xen/arm: vpl011: Move vgic register access functions to vreg.h

[Julien Grall <julien.grall@xxxxxxx>]

Hi Bhupinder,

On 06/06/17 18:25, Bhupinder Thakur wrote:
> These functions are generic in nature and can be reused by other emulation
> code in Xen. One recent example is pl011 emulation, which needs similar
> functions to read/write the registers.
>
> This patch moves the register access function definitions from vgic.h to
> vreg.h.
>
> Signed-off-by: Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>
> ---
> CC: ss
> CC: jg
>
> Changes since v3:
> - Moved the macro call VGIC_REG_HELPERS to vreg.h from vgic.h.
>
>  xen/include/asm-arm/vgic.h | 111 +--------------------------------------------
>  xen/include/asm-arm/vreg.h | 110 ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 111 insertions(+), 110 deletions(-)
>
> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> index 544867a..75c716e 100644
> --- a/xen/include/asm-arm/vgic.h
> +++ b/xen/include/asm-arm/vgic.h
> @@ -20,6 +20,7 @@
>
>  #include <xen/bitops.h>
>  #include <asm/mmio.h>
> +#include <asm-arm/vreg.h>
You should include asm/vreg.h and not asm-arm/vreg.h. With that fixed:

Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel