Re: [Xen-devel] [Xen-devel[PATCH Resend v2] xen: common: rbtree: ported updates from linux tree

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote:
> Hi All,
> 
Hi,

> The patch imports the changes and updates of the rbtree
> implementaiton
> from Linux tree. 
>
Thanks Praveen for doing this.

This series is much better than the previous single and giant patch.
:-)

> But since, the only current implementation is with tmem.c,
> which am not much aware off much and therefore, was unable to test
> the changes
> thoroughly. Having said that, I do have plans of adding futher code
> changes
> which will be using rb-tree more in credit2 scheduler and that will
> help in
> further testing the same.
>
That is fine, I think, for now. We'll test this properly when you'll
have the "usage in Credit2" part.
> 
> I have not imported augmented and rcu rbtree functionality to the xen
> tree,
> as there was no specific requirement for current planned
> implementation.
> 
That's something I agree with, and you did the right thing saying it
here in the cover letter. Another thing I would like to know, though,
is whether there are other commits that, for one reason or another, you
either decided to skip, or could not port, or if this series bring us
basically on par with Linux's rb-trees.

> From Praveen Kumar <kpraveen.lkml@xxxxxxxxx> # This line is ignored.
> From: Praveen Kumar <kpraveen.lkml@xxxxxxxxx>
> Subject: 
> In-Reply-To: 
> 
This are a bit strange lines. No big deal, just saying.

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel