[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v11 10/23] x86: refactor psr: L3 CAT: set value: implement cos finding flow.

>>> On 03.05.17 at 10:44, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
>  static int find_cos(const uint32_t val[], unsigned int array_len,
>                      enum psr_feat_type feat_type,
>                      const struct psr_socket_info *info)
>  {
> +    unsigned int cos, i;
> +    const unsigned int *ref = info->cos_ref;
> +    const struct feat_node *feat;
> +    unsigned int cos_max;

Please can you declare all the "unsigned int"-s on one line? (i, btw,
should go into the for scope.)

Looks good otherwise, but again earlier comments apply.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.