[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies

On 25/05/17 16:45, Ian Jackson wrote:
Thanks to everyone for testing and review and acks.  I have just
pushed those two commits to staging.

Roger Pau Monné writes ("Re: [Xen-devel] [PATCH for-4.9 2/2] Makefile: Regularise 
subdir targets and their dependencies"):
Maybe it would be good to add a note like:

"All the Makefiles invoked with -C from the toplevel should have the
following targets: all, build, install, clean, distclean"

Yes, indeed.  How about the extra patch below ?
There are some special cases, so I think `generally' is right.

I'll wait a bit for opinions, but given that this is a comment-only
patch I guess Julien's exception for docs applies, so I will probably
commit it tomorrow unless someone objects.

That's right. However, I'd like to try branching tomorrow so we need staging != master.

Could you hold the patch until we branch? (I will send an e-mail for a commit moratorium).


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.