[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.9 2/2] Makefile: Regularise subdir targets and their dependencies

Thanks to everyone for testing and review and acks.  I have just
pushed those two commits to staging.

Roger Pau Monné writes ("Re: [Xen-devel] [PATCH for-4.9 2/2] Makefile: 
Regularise subdir targets and their dependencies"):
> Maybe it would be good to add a note like:
> "All the Makefiles invoked with -C from the toplevel should have the
> following targets: all, build, install, clean, distclean"

Yes, indeed.  How about the extra patch below ?
There are some special cases, so I think `generally' is right.

I'll wait a bit for opinions, but given that this is a comment-only
patch I guess Julien's exception for docs applies, so I will probably
commit it tomorrow unless someone objects.


From 352f4a1f9797d1eee94121565fb4e3d8fc698371 Mon Sep 17 00:00:00 2001
From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Date: Thu, 25 May 2017 16:42:12 +0100
Subject: [PATCH] Makefile: Mention usual targets of subdir Makefiles
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Suggested-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
CC: Wei Liu <wei.liu2@xxxxxxxxxx>
CC: M A Young <m.a.young@xxxxxxxxxxxx>
CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
 Makefile | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Makefile b/Makefile
index 51905eb..2ff33df 100644
--- a/Makefile
+++ b/Makefile
@@ -90,6 +90,11 @@ test:
 # Also, we have a number of targets COMPONENT which run
 # dist-COMPONENT, for convenience.
+# The Makefiles invoked with -C from the toplevel should
+# generally have the following targets:
+#       all  build  install  clean  distclean
 .PHONY: dist
 dist: DESTDIR=$(DISTDIR)/install

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.