Re: [Xen-devel] [PATCH v2 03/18] x86/traps: lift do_guest_trap to domain.h

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 12/05/17 19:16, Andrew Cooper wrote:
> On 05/05/17 15:48, Wei Liu wrote:
>> Put it along side with other pv_inject functions and rename it to
>> pv_inject_trap.
>>
>> We need this because this function is used by PV emulation code and PV
>> trap handling code, which will be split into different files.
>>
>> No functional change.
>>
>> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> On further thought, it might be better to use this patch instead, which
> drops do_guest_trap() in favour of better alternatives, and in a manor
> more consistent with HVM guests.
>
> Thoughts?

On yet further thought, this patch actually fixes guest stack corruption
if the PV kernel uses int $x for vectors with an error code (or
configures such vectors to be accessable to userspace).

This was actually a regression introduced by me in 2e426d6eecf, and
6480cc6280e really should have made the regression much more obvious...

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel