[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 04/10] xen/arm: vpl011: Provide a knob in libxl to enable/disable pl011 emulation



Hi,

On 19/04/17 11:25, Wei Liu wrote:
On Wed, Apr 19, 2017 at 02:47:08PM +0530, Bhupinder Thakur wrote:
Hi,

On 19 April 2017 at 05:59, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
I think "console" is confusing an emulated device with xenconsole.

I would use vuart=pl011 to clarify that we are specifying a new
component for emulation.

Throughout the code, I am using "vconsole" or "vcon" as a prefix for
most of the code. Should I replace "vconsole" with "vuart" at all such
places? I did not use "vuart" initially as there was some existing
code in Xen under vuart.c.

That would be fine by me. But I don't know enough of ARM to make
judgement. Please wait for Stefano or Julien to reply.

The name "vuart" makes more sense to use for the user point of view.

Regarding vuart.c, this is just a name of a file that is used to expose a very limited UART to DOM0 that mimic the host UART. In the future we may want to expose something similar for guest running unmodified OS and target a specific hardware.

We can rename the file if it is too confusing.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.