[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v10 09/25] x86: refactor psr: L3 CAT: set value: implement framework.
- To: "Yi Sun" <yi.y.sun@xxxxxxxxxxxxxxx>
- From: "Jan Beulich" <JBeulich@xxxxxxxx>
- Date: Tue, 18 Apr 2017 05:46:43 -0600
- Cc: kevin.tian@xxxxxxxxx, wei.liu2@xxxxxxxxxx, he.chen@xxxxxxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, dario.faggioli@xxxxxxxxxx, ian.jackson@xxxxxxxxxxxxx, mengxu@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, chao.p.peng@xxxxxxxxxxxxxxx, roger.pau@xxxxxxxxxx
- Delivery-date: Tue, 18 Apr 2017 11:46:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
>>> On 18.04.17 at 12:55, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
> I made a test patch based on v10 and attached it in mail. Could you please
> help to check it? Thanks!
This looks reasonable at the first glance, albeit I continue to be
unconvinced that this is the only (reasonable) way of solving the
problem. After all we don't have to go through similar hoops for
any other of the register state associated with a vCPU. There
are a number of cosmetic issues, but commenting on an attached
(rather than inlined) patch is a little difficult.
One remark regarding the locking though: Acquiring a lock in the
context switch path should be made as low risk of long stalls as
possible. Therefore you will want to consider using r/w locks
instead of spin locks here, which would allow parallelism on all
cores of a socket as long as COS IDs aren't being updated.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
