Re: [Xen-devel] [PATCH v3] xen, input: add xen-kbdfront module parameter for setting resolution

[Juergen Gross <jgross@xxxxxxxx>]

On 12/04/17 17:16, Dmitry Torokhov wrote:
> Hi Juergen,
> 
> On Tue, Apr 11, 2017 at 02:30:37PM +0200, Juergen Gross wrote:
>> Add a parameter for setting the resolution of xen-kbdfront in order to
>> be able to cope with a (virtual) frame buffer of arbitrary resolution.
>>
>> While at it remove the pointless second reading of parameters from
>> Xenstore in the device connection phase: all parameters are available
>> during device probing already and that is where they should be read.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>> ---
>> V3: - merged the two patches
>>     - read Xenstore parameters during probing of the device only
> 
> I guess 2 module parameters are not big deal, but could you tell me why
> you can't always have them specified in Xenstore?

This will depend on Xen version then. I'd prefer to have a way to
specify the resolution in case a new kernel is running as a guest
of an old Xen version.

> Also, I still think you are going in the wrong direction here. Can your
> framebuffer size change after booting the guest? If it can, you have to
> reconcile the new size and the coordinates reported by the pointing
> device, and I think guest should be doing it. If you look, for example,
> at vmmouse driver, they do not try to match coordinates it reports to
> the screen.

I'm no expert in input driver interface. Can you tell me how the mouse
pointer is positioned in case of the vmmouse driver? Are the real limits
used just the minimum of pointing device and screen size limits? So
specifying a size of 0xffff * 0xffff like the vmmouse driver does will
work with any screen size being smaller than that?


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel