Re: [Xen-devel] [PATCH v3] xen, input: add xen-kbdfront module parameter for setting resolution

[Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>]

Hi Juergen,

On Tue, Apr 11, 2017 at 02:30:37PM +0200, Juergen Gross wrote:
> Add a parameter for setting the resolution of xen-kbdfront in order to
> be able to cope with a (virtual) frame buffer of arbitrary resolution.
> 
> While at it remove the pointless second reading of parameters from
> Xenstore in the device connection phase: all parameters are available
> during device probing already and that is where they should be read.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> V3: - merged the two patches
>     - read Xenstore parameters during probing of the device only

I guess 2 module parameters are not big deal, but could you tell me why
you can't always have them specified in Xenstore?

Also, I still think you are going in the wrong direction here. Can your
framebuffer size change after booting the guest? If it can, you have to
reconcile the new size and the coordinates reported by the pointing
device, and I think guest should be doing it. If you look, for example,
at vmmouse driver, they do not try to match coordinates it reports to
the screen.

Thanks.

-- 
Dmitry

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel